Re: [libvirt] [PATCH] Split contents of <cmdline>...</cmdline> and set LXC init argv
On Wed, Mar 14, 2012 at 12:00:04PM -0600, Eric Blake wrote:
On 03/14/2012 11:53 AM, Daniel P. Berrange wrote:
> In other words, I don't think it is acceptable to automagically
> split '<cmdline>' and pass them as argv[]. We should only
> use it for setting LIBVIRT_LXC_CMDLINE.
>
> We should add a separate <initarg> element for setting init's
> argv[] I think
as in:
<cmdline>complex value that we won't split</cmdline>
<initarg>arg1</initarg>
<initarg>arg2, with funky '"\ stuff</initarg>
Yes, that sounds like a more sure-fire way of letting the user specify
exactly what they wanted, and nicer for XPath queries too.
Yes, exactly.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|