Re: [libvirt PATCH 2/2] meson: Add tests_timeout build option
On Wed, Sep 09, 2020 at 04:17:21PM +0200, Andrea Bolognani wrote:
On Wed, 2020-09-09 at 15:01 +0100, Daniel P. Berrangé wrote:
> On Wed, Sep 09, 2020 at 03:56:08PM +0200, Andrea Bolognani wrote:
> > Taking a step back,
> > what are the reasons one might want to call either meson or ninja to
> > run the test suite?
>
> It appears that 'ninja test' is just a dumb shim to invoke
> 'meson test'. Given that using meson test directly looks
> much saner as you get the full range of functionality
> available.
I think it's the other way around, isn't it? That is, 'meson test'
is a wrapper for 'ninja test' which adds a bunch of functionality on
top.
That's not what the build.ninja says:
build meson-test: CUSTOM_COMMAND all PHONY
COMMAND = /usr/bin/meson test --no-rebuild --print-errorlogs
DESC = Running$ all$ tests.
pool = console
build test: phony meson-test
There's nothing else in the build.ninja that refers to execution
of tests - it merely builds them.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|