Re: [libvirt] [PATCH v2 2/3] qemu: vfio-ap device support

On Mon, Oct 22, 2018 at 10:10:39AM +0200, Boris Fiuczynski wrote: > On 10/19/18 1:56 PM, Thomas Huth wrote: >> On 2018-10-18 16:54, Boris Fiuczynski wrote: >>> Adjusting domain format documentation, adding device address >>> support and adding command line generation for vfio-ap. >>> Since only one mediated hostdev with model vfio-ap is supported a check >>> disallows to define domains with more than one such hostdev device. >>> >>> Signed-off-by: Boris Fiuczynski <fiuczy(a)linux.ibm.com&gt; >>> Reviewed-by: Bjoern Walk <bwalk(a)linux.ibm.com&gt; >> [...] >>> +static int >>> +virDomainDefPostParseHostdev(virDomainDefPtr def) >>> +{ >>> + size_t i; >>> + bool vfioap_found = false; >>> + >>> + /* verify settings of hostdevs vfio-ap */ >>> + for (i = 0; i < def->nhostdevs; i++) { >>> + virDomainHostdevDefPtr hostdev = def->hostdevs[i]; >>> + >>> + if (virHostdevIsMdevDevice(hostdev) && >>> + hostdev->source.subsys.u.mdev.model == VIR_MDEV_MODEL_TYPE_VFIO_AP) { >>> + if (vfioap_found) { >>> + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", >>> + _("Only one hostdev of model vfio-ap is " >>> + "support")); >> >> s/support/supported/ ? > It should be "supported"... :-) > > I hope whoever is going to push this series can fix it before pushing. If > not please let me know and I am going to send a v3. Hi Boris, I'm planning on having a look at the series too (sorry for not taking a look earlier, I was on PTO and the whole team is now attending KVM forum). Anyhow, if it turns out the typo is the only issue, that will be fixed before merging, no brainer :). Erik -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list