Re: [libvirt] [PATCHv4 09/18] blockjob: expose qemu commands for mirrored storage migration
On 04/13/2012 06:31 AM, Jiri Denemark wrote:
On Mon, Apr 09, 2012 at 21:52:18 -0600, Eric Blake wrote:
> As mentioned several commits ago when the capability bits were added,
> the new block copy storage migration sequence requires both the
> 'drive-mirror' and 'drive-reopen' monitor commands.
>
> +
> + if (mon->json)
> + ret = qemuMonitorJSONDriveMirror(mon, actions, device, file, format,
> + flags);
> + else
> + qemuReportError(VIR_ERR_INVALID_ARG, "%s",
> + _("drive-mirror requires JSON monitor"));
Why is this VIR_ERR_INVALID_ARG instead of VIR_ERR_CONFIG_UNSUPPORTED?
Probably copy-and-paste, but worth fixing along the same lines as the
other message about "qemu binary" being too old.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)