Re: [libvirt PATCH v2 03/15] conf: move/rename hostdev PCI driver type enum to device_conf.h

On Mon, Nov 06, 2023 at 02:38:48 -0500, Laine Stump wrote: > Currently this enum is defined in domain_conf.h and named > virDomainHostdevSubsysPCIDriverType. I want to use it in parts of the > network and networkport config, so am moving its definition to > device_conf.h which is / can be included by all interested parties, > and renaming it to be less specific to its old usage (all the other > parts still apply, at least functionally, to the new usage). The name > change (which includes enum values) does cause a lot of churn, but > it's all mechanical. > > Signed-off-by: Laine Stump <laine(a)redhat.com&gt; > --- [...] > @@ -23342,8 +23335,9 @@ virDomainHostdevDefFormatSubsysPCI(virBuffer *buf, > virBufferAsprintf(&sourceAttrBuf, " writeFiltering='%s'", > virTristateBoolTypeToString(def->writeFiltering)); > > - if (pcisrc->backend != VIR_DOMAIN_HOSTDEV_PCI_BACKEND_DEFAULT) { > - const char *backend = virDomainHostdevSubsysPCIBackendTypeToString(pcisrc->backend); > + if (pcisrc->backend != VIR_DEVICE_HOSTDEV_PCI_DRIVER_TYPE_DEFAULT) { > + const char *backend > + = virDeviceHostdevPCIDriverTypeToString(pcisrc->backend); Please no pointless linebreaks. The times of max 80 colums are gone.