Re: [libvirt] [PATCH] Fix several formatting mistakes in doc
On 03/31/2011 08:13 AM, Eric Blake wrote:
> This exposes several problems in the docs/Makefile.am
>
> - make clean doesn't work in a VPATH build because
> for some reason the HTML is generated in the $srcdir
Intentional - docs are machine independent and therefore may be
distributed, and by distributing them, others don't have to have the
tools to rebuild them. Distributed files should generally be built in
srcdir
> and so 'rm -f *.html' misses the files
So that's the real bug - the clean hook needs to be prefixed with $(srcdir).
Actually, 'make clean' must _not_ remove generated files. Otherwise,
there's no point in shipping them pre-generated - the first 'make clean'
would nuke them and the user without the tools to regenerate them would
be stuck. Rather, 'make maintainer-clean' should be taught how to
remove them, since the maintainer is expected to have the necessary
extra prerequisite tools.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)