Re: [libvirt] patch for openvz driver to support vzctl 3.1
On 04/04/2012 10:59 AM, Ilja Livenson wrote:
Hi,
there was a recent update of vzctl from openvz, which made openvz
driver crash: https://www.redhat.com/archives/libvirt-users/2012-March/msg00203.html
Not sure about the correct procedure, but the patch is very simple and
is shown here: https://bugzilla.redhat.com/show_bug.cgi?id=809895 .
Basically, openvz dropped strict version numbering (3.1 vs 3.1.0),
which caused parsing to fail.
Thanks for the heads up. Some advice for next time: when posting a
patch to a list, post the actual patch, and not a URL to some other
location where the patch is embedded. It goes back to the principle of
making the maintainer's life as easy as possible - if you make the
maintainer do the legwork that you could have done, then your patch goes
to the bottom of the queue. Also, your patch was reversed (it is
traditional to diff old as -, new as +).
That said, I've given you enough grief for one day, so ACK, and I pushed
your patch as well as adding you to AUTHORS. Let me know if you prefer
an alternate spelling.
patch is quite simple:
--- src/openvz/openvz_conf.c
+++ src/openvz/openvz_conf.c
@@ -99,7 +99,7 @@ openvzExtractVersionInfo(const char *cmd
if ((tmp = STRSKIP(tmp, "vzctl version ")) == NULL)
goto cleanup;
- if (virParseVersionString(tmp, &version, true) < 0)
+ if (virParseVersionString(tmp, &version, false) < 0)
goto cleanup;
if (retversion)
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)