Re: [libvirt] [PATCH] introducing <source> <name> (for logical storage pools)
David Lively <dlively(a)virtualiron.com> wrote:
Oops - that was against an old base. Sorry. Here's the new one.
Good timing.
I was in the process of replying,
after having done the merge and add-conn-arg bit.
Also fixed a few other issues ...
ACK.
I compared the result of my merge/tweaks and your new patch
and see you fixed everything I saw. The only difference was
that when I inserted "conn, " and it pushed past the 80-col
limit, I split the line:
diff --git a/src/storage_conf.c b/src/storage_conf.c
index e49f684..74c3f1e 100644
--- a/src/storage_conf.c
+++ b/src/storage_conf.c
@@ -328,3 +329,4 @@ virStoragePoolDefParseDoc(virConnectPtr conn,
if (options->flags & VIR_STORAGE_BACKEND_POOL_SOURCE_NAME) {
- ret->source.name = virXPathString(conn, "string(/pool/source/name)",
ctxt);
+ ret->source.name = virXPathString(conn,
"string(/pool/source/name)",
+ ctxt);
if (ret->source.name == NULL) {