The summary line mentions a different name than the one used for the
test.
On Tue, Jul 22, 2025 at 13:50:18 -0400, Aaron M. Brown wrote:
Add test coverage for multiple virtio consoles on a virtio-serial
controller.
This test makes sure that multiple virtconsoles get auto-assigned appropriate
port numbers on a virtio-serial-bus
Signed-off-by: Aaron M. Brown <aaronmbr(a)linux.ibm.com>
---
...rial-autoassign-address.x86_64-latest.args | 44 +++++++++++++
...erial-autoassign-address.x86_64-latest.xml | 63 +++++++++++++++++++
...nsole-virtio-serial-autoassign-address.xml | 48 ++++++++++++++
tests/qemuxmlconftest.c | 1 +
4 files changed, 156 insertions(+)
create mode 100644
tests/qemuxmlconfdata/console-virtio-serial-autoassign-address.x86_64-latest.args
create mode 100644
tests/qemuxmlconfdata/console-virtio-serial-autoassign-address.x86_64-latest.xml
create mode 100644 tests/qemuxmlconfdata/console-virtio-serial-autoassign-address.xml
[...]
diff --git
a/tests/qemuxmlconfdata/console-virtio-serial-autoassign-address.xml
b/tests/qemuxmlconfdata/console-virtio-serial-autoassign-address.xml
new file mode 100644
index 0000000000..229572156e
--- /dev/null
+++ b/tests/qemuxmlconfdata/console-virtio-serial-autoassign-address.xml
@@ -0,0 +1,48 @@
+<domain type='qemu'>
+ <name>QEMUGuest1</name>
+ <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
+ <memory unit='KiB'>219100</memory>
+ <currentMemory unit='KiB'>219100</currentMemory>
+ <vcpu placement='static' cpuset='1-4,8-20,525'>1</vcpu>
I'll also drop these definitions ...
+ <os>
+ <type arch='x86_64' machine='pc'>hvm</type>
+ <boot dev='hd'/>
+ </os>
+ <clock offset='utc'/>
+ <on_poweroff>destroy</on_poweroff>
+ <on_reboot>restart</on_reboot>
+ <on_crash>destroy</on_crash>
+ <devices>
+ <emulator>/usr/bin/qemu-system-x86_64</emulator>
+ <disk type='block' device='disk'>
+ <source dev='/dev/HostVG/QEMUGuest1'/>
+ <target dev='hda' bus='ide'/>
+ <address type='drive' controller='0' bus='0'
target='0' unit='0'/>
+ </disk>
... which are not strictly needed to test consoles.
+ <controller type='usb' index='0'/>
+ <controller type='ide' index='0'/>
+ <controller type='virtio-serial' index='0'/>
+ <controller type='pci' index='0' model='pci-root'/>
+ <serial type='pty'>
+ <target port='0'/>
+ </serial>
+ <console type='pty'>
+ <target type='serial' port='0'/>
+ </console>
+ <console type='pty'>
+ <target type='virtio' port='1'/>
+ <address type='virtio-serial' controller='0'/>
+ </console>
+ <console type='pty'>
+ <target type='virtio' port='2'/>
+ <address type='virtio-serial' controller='0'/>
+ </console>
+ <console type='pty'>
+ <target type='virtio' port='3'/>
+ <address type='virtio-serial' controller='0'/>
+ </console>
+ <input type='mouse' bus='ps2'/>
+ <input type='keyboard' bus='ps2'/>
+ <memballoon model='virtio'/>
+ </devices>
+</domain>
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
I'll address the few things I've pointed out myself.