Re: [libvirt] [PATCHv2 15/16] save: support bypass-cache flag in libvirt-guests init script
On Tue, Jul 19, 2011 at 10:20:38PM -0600, Eric Blake wrote:
libvirt-guests is a perfect use case for bypassing the file system
cache - lots of filesystem traffic done at system shutdown, where
caching is pointless, and startup, where reading large files only
once just gets in the way. Make this a configurable option in the
init script, but defaulting to existing behavior.
* tools/libvirt-guests.sysconf (BYPASS_CACHE): New variable.
* tools/libvirt-guests.init.sh (start, suspend_guest): Use it.
---
merge 10 and 18 of v1, rename SAVE_DIRECT to BYPASS_CACHE
tools/libvirt-guests.init.sh | 10 ++++++++--
tools/libvirt-guests.sysconf | 5 +++++
2 files changed, 13 insertions(+), 2 deletions(-)
ACK
Side note: we need to figure out something better than this horrible
shell script for autostart/autoshutdown, so that we fit in better
with systemd.
We might want to come up with a custom 'virsh host-shutdown' and
'virsh host-startup' command, which would let us write a really
trivial systemd unit file to do this, avoiding the horrible shell
code.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|