Re: [libvirt] [PATCH 7/7] libvirt-domain: Document interface stats POV
On 10/02/2017 11:05 AM, Michal Privoznik wrote:
Interestingly enough, we don't document the point of view of the
interface statistics. Therefore it's unknown to users if for
instance rx_packets is the number of packets received by domain or
received by host (from domain). Document this explicitly.
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
src/libvirt-domain.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Maybe we should be even more explicit vis-a-vis when certain types of
interface stats are swapped - direct & ethernet keep the same/current
view, but every other type is changing. I know/understand this is a
"tricky" and "slippery" slope in order to keep up with in the future,
but I think some wording could be generated that would suffice
Also a followup patch should modify docs/news.xml!
Reviewed-by: John Ferlan <jferlan(a)redhat.com>
John