Re: [libvirt] [PATCH 3/3] docs: Remove unused JS libraries
On Wed, 2019-06-19 at 17:22 +0200, Martin Kletzander wrote:
[...]
javascript = \
- js/main.js \
- js/jquery-3.1.1.min.js \
- js/jquery.rss.min.js \
- js/moment.min.js
-
+ js/main.js
Please keep the list as
javascript = \
js/main.js \
$(NULL)
Smaller diff, both right now and in the future :)
[...]
<!DOCTYPE html>
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
- <script type="text/javascript"
src="js/jquery-3.1.1.min.js"> </script>
- <script type="text/javascript" src="js/moment.min.js">
</script>
- <script type="text/javascript" src="js/jquery.rss.min.js">
</script>
</head>
You can get rid of <head> entirely now.
With the above addressed,
Reviewed-by: Andrea Bolognani <abologna(a)redhat.com>
but please give Dan a chance to raise any concerns he might have
before pushing :)
--
Andrea Bolognani / Red Hat / Virtualization