Re: [PATCH v1] virtqemud: remove sysconfig file
Am Fri, 16 Jul 2021 00:58:43 -0700
schrieb Andrea Bolognani <abologna(a)redhat.com>:
The sysconfig files shipped with libvirt contain the defaults, and
the admin is absolutely welcome to tweak them however they might like
after installation, just as is the case for all the configuration
files in /etc/libvirt.
Right. Once they are modified for whatever reason things will go downhill.
Just recently the default (for libvirtd) changed from --listen to --timeout.
This is an incompatible change. There is very little info on the system to
workout if the admin actually wanted --listen, and just append some other knob,
or if he dirtied the sysconfig file in other ways. Therefore %post or %posttrans
scripts have no easy way to decide what to do with the existing sysconfig file
to switch to the new default.
If --listen would have been configured like I proposed, any admin changes are
clear and obvious, and he has to keep the pieces if it falls apart because
some default changed. In this case from .service to .socket activation.
Furthermore my change should also add every undocumented variable to the service file.
Configuration files are not documentation files.
This is also violated, but should probably be discussed on another Friday.
Olaf
Attachments:
- attachment.sig (application/pgp-signature — 833 bytes)