Re: [libvirt] [PATCH] tools: fix a judgment of equalling zero about an array's length
-----Original Message-----
From: libvir-list-bounces(a)redhat.com
[mailto:libvir-list-bounces@redhat.com]
On Behalf Of lawrancejing
Sent: Friday, September 13, 2013 10:00 AM
To: libvir-list(a)redhat.com
Cc: lawrancejing
Subject: [libvirt] [PATCH] tools: fix a judgment of equalling zero about
an
array's
length
There is no need to go on executing code when the array's length is zero.
---
tools/virsh-snapshot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index e37a5b3..d7a4c7b 100644
--- a/tools/virsh-snapshot.c
+++ b/tools/virsh-snapshot.c
@@ -239,7 +239,7 @@ vshParseSnapshotMemspec(vshControl *ctl,
virBufferPtr buf, const char *str)
return 0;
narray = vshStringToArray(str, &array);
If str is NULL, we could get a array sized 1(a NULL element at the end), or
some
negative values if error occurred.
So don't worry about 0 would return from vshStringToArray.
- if (narray < 0)
+ if (narray <= 0)
goto cleanup;
for (i = 0; i < narray; i++) {
--
1.7.1
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list