Re: [libvirt] [PATCH v3 08/13] Rename all PCI device functions to have a standard name prefix
On 02/05/2013 08:07 AM, Daniel P. Berrange wrote:
On Mon, Feb 04, 2013 at 06:31:10PM +0100, Jiri Denemark wrote:
> On Fri, Feb 01, 2013 at 11:18:30 +0000, Daniel P. Berrange wrote:
>> From: "Daniel P. Berrange" <berrange(a)redhat.com>
>>
>> Rename all the pciDeviceXXX and pciXXXDevice APIs to have a
>> fixed virPCIDevice name prefix
>
> ACK whether you implement changes I suggested or not (or just
some of
> them) as long as make all check syntax-check succeeds.
Will fix them all
I believe this patch is the cause of my build failures on RHEL 6:
CC libvirt_driver_nodedev_la-node_device_hal.lo
cc1: warnings being treated as errors
node_device/node_device_hal.c: In function 'gather_pci_cap':
node_device/node_device_hal.c:151: error: implicit declaration of
function 'pciGetPhysicalFunction' [-Wimplicit-function-declaration]
node_device/node_device_hal.c:151: error: nested extern declaration of
'pciGetPhysicalFunction' [-Wnested-externs]
node_device/node_device_hal.c:154: error: implicit declaration of
function 'pciGetVirtualFunctions' [-Wimplicit-function-declaration]
node_device/node_device_hal.c:154: error: nested extern declaration of
'pciGetVirtualFunctions' [-Wnested-externs]
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)