On 04/02/2014 12:12 AM, Martin Kletzander wrote:
>> +static int qemuAgentCheckError(virJSONValuePtr cmd,
virJSONValuePtr
>> reply);
>> +
>
> Is it worth hoisting this function into topological order, so we don't
> need a forward declaration? But that's better as a followup patch
> (no-op code motion should be separate from refactoring).
>
> ACK
>
Thank you, I've pushed it. Would the following suffice as the mentioned
follow-up? Or do you want me to send a new standalone patch for that?
This mail is good enough; ACK, go ahead and push that reorder as a
formal patch.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org