On 07/05/2011 01:45 AM, Laine Stump wrote:
virtPortProfiles are currently only used in the domain XML, but will
soon also be used in the network XML. To prepare for that change, this
patch moves the structure definition into util/network.h and the parse
and format functions into util/network.c (I decided that this was a
better choice than macvtap.h/c for something that needed to always be
available on all platforms).
Additionally, the virtPortProfile in the domain interface struct is
now a separately allocated object rather *pointed to by* (rather than
grammar nit - you can delete the first "rather"
contained in) the main virDomainNetDef object. This is done to make
is
s/is/it/
easier to figure out when a virtualPortProfile has/hasn't been
specified in a particular config.
---
src/conf/domain_conf.c | 208 +++------------------------------------------
src/conf/domain_conf.h | 2 +-
src/libvirt_private.syms | 2 +
src/qemu/qemu_command.c | 4 +-
src/qemu/qemu_hotplug.c | 2 +-
src/qemu/qemu_migration.c | 4 +-
src/qemu/qemu_process.c | 2 +-
src/util/macvtap.c | 6 +-
src/util/macvtap.h | 36 +--------
src/util/network.c | 196 ++++++++++++++++++++++++++++++++++++++++++
src/util/network.h | 47 ++++++++++
11 files changed, 271 insertions(+), 238 deletions(-)
ACK. Looks like pretty clean code motion, plus fallout due to a slight
parameter change and alteration of who is responsible for actually
reporting error messages.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library
http://libvirt.org