Re: [libvirt] [PATCH] introduce VIR_CLOSE to be used rather than close()
On 10/15/2010 12:26 PM, Stefan Berger wrote:
>
> No change in src/libvirt_private.syms?
>
Was waiting for the linker to complain and it did not.
My understanding is that the *.syms files are important mainly if you
build with --with-driver-modules, but that defaults to no. Without it,
you get a single binary (where the link is satisfied) rather than
multiple .so (where the .syms file is essential to avoid link failures
in the various driver modules), so the default build hides whether you
really need to add it.
Given that danpb's recent 4-patch series to add auditing points had to
export a lot more symbols, we obviously don't do much testing of module
builds. So I'd feel better seeing it added, even if you haven't yet
configured in a manner that would provoke link failure without it.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org