Re: [libvirt PATCH] rpm: more fixes for disabling features
On Mon, Nov 02, 2020 at 12:45:21PM +0000, Daniel P. Berrangé wrote:
The %meson macro sets "--auto-features=enabled", so it is
not enough to
disable the driver options, we must also disable any library options
which the drivers depend on.
Signed-off-by: Daniel P. Berrangé <berrange(a)redhat.com>
---
libvirt.spec.in | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 06afd0dab8..1b6a9596d8 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -1026,15 +1026,15 @@ exit 1
%endif
This fixes the current issue with RPM dependencies so I'm willing to
give it an ACK, however, I would like to propose to get rid of the
library specific options if the library is used only by single driver,
the library is mandatory for that driver.
Historically we had all of the libraries with autoconf because it was
possible to provide a custom path to a library using the build option
in addition to enable/disable state. With meson it is no longer
possible and users have to use different ways to provide custom path
for libraries.
Pavel
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)