Tatsuro Enokura wrote:
Hi,
I found a bug about negative value at virConfParseLong() in conf.c.
This patch fixes it.
Signed-off-by: Tatsuro Enokura <fj7716hz(a)aa.jp.fujitsu.com>
Thanks,
Tatsuro Enokura.
--------------------------------------------------------------------------
Index: libvirt/src/conf.c
===================================================================
RCS file: /data/cvs/libvirt/src/conf.c,v
retrieving revision 1.11
diff -u -p -r1.11 conf.c
--- libvirt/src/conf.c 4 Jul 2007 09:16:23 -0000 1.11
+++ libvirt/src/conf.c 19 Oct 2007 08:37:36 -0000
@@ -345,6 +345,8 @@ virConfParseLong(virConfParserCtxtPtr ct
l = l * 10 + (CUR - '0');
NEXT;
}
+ if (neg)
+ l *= -1;
*val = l;
return(0);
}
Good catch!
+1
Rich.
--
Emerging Technologies, Red Hat -
http://et.redhat.com/~rjones/
Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod
Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in
England and Wales under Company Registration No. 03798903