Re: [PATCH v2 1/4] qemu.conf changes to support multiple memory backend
Ok, I tested one of your concerns below, and I caught that already.
Just following up......
On 8/6/24 07:35, Martin Kletzander wrote:
On Wed, Jun 05, 2024 at 04:37:35PM -0400, mgalaxy(a)akamai.com wrote:
> From: Michael Galaxy <mgalaxy(a)akamai.com>
> + _("Domain requesting configuration
> for %1$lu NUMA nodes, but memory backing directory only has (%2$lu)
> directory paths available. Either reduce this to one directory or
> provide more paths to use."),
> + numa_node_count,
> + cfg->nb_memoryBackingDirs);
> + return -1;
> + }
> +
> + path_index = virBitmapNextSetBit(numaBitmap, -1);
What if the single pinning is to the third host node, but there are only
two memoryBackingDirs supplied in the config?
I tested this. This case was already covered by this conditional check
that I included in the v2 patch:
+ if (cfg->nb_memoryBackingDirs < numa_node_count) {
+ virReportError(VIR_ERR_INTERNAL_ERROR,
+ _("Domain requesting configuration for %1$lu NUMA
nodes, but memory backing directory only has (%2$lu) directory paths available. Either
reduce this to one directory or provide more paths to use."),
+ numa_node_count,
+ cfg->nb_memoryBackingDirs);
+ return -1;
+ }
- Michael