Re: [libvirt] [PATCH 1/2] Add domain support for virtio channel
On Thu, Feb 18, 2010 at 03:29:13PM +0000, Matthew Booth wrote:
On 18/02/10 14:09, Daniel P. Berrange wrote:
> On Thu, Feb 18, 2010 at 01:16:02PM +0000, Matthew Booth wrote:
>> On 18/02/10 12:34, Daniel P. Berrange wrote:
>>> On Wed, Feb 17, 2010 at 05:11:00PM +0000, Matthew Booth wrote:
>>>> Add support for virtio-serial by defining a new 'virtio' channel
target type and
>>>> a virtio-serial controller. Allows the following to be specified in a
domain:
[...]
Updated patch attached.
[...]
@@ -4905,11 +5055,18 @@ virDomainChrDefFormat(virBufferPtr buf,
break;
}
+ case VIR_DOMAIN_CHR_TARGET_TYPE_VIRTIO:
+ virBufferAddLit(buf, " <target type='virtio'");
+ if (def->target.name) {
+ virBufferVSprintf(buf, " name='%s'", def->target.name);
I changed that to use virBufferEscapeString as the string comes from
the user XML input.
+ }
+ virBufferAddLit(buf, "/>\n");
+ break;
+
ACK, and pushed, thanks !
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/