Re: [libvirt] [PATCHv5 0/9] add command numatune (Re: [PATCHv3 0/8] add command numatune)
On 12/20/2011 01:27 AM, Hu Tao wrote:
> I still think we need a v5, containing my various improvements
(which
> I'll post as v4), and addressing these additional concerns:
>
> Is tools/virsh.c allowed to directly use conf/domain_conf.h, or must we
> move the string conversion of numa mode into src/util?
Maybe a later patch to do this because there are a lot of unrelated
type-string conversion codes?
Yes, I'm okay with a later cleanup if someone argues that including
conf/domain_conf.h from tools/virsh.c was wrong.
As such, ACK series and now pushed.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)