Re: [PATCH v1] virdnsmasq: fix runtime search for executable

On Wed, Aug 11, 2021 at 11:47:13AM +0200, Olaf Hering wrote: > dnsmasq is an optional binary which does not neccessary exist during build. > > Signed-off-by: Olaf Hering <olaf(a)aepfle.de&gt; > --- > src/util/virdnsmasq.c | 28 +++++++++++++++++++++++----- > 1 file changed, 23 insertions(+), 5 deletions(-) Is there any error or incorrect behavior that you are trying to fix? I did audit the code and within the virdnsmasq.c file we use the binaryPath with virCommandRun() which will do this same check before acutally execing, see virExec().