On 12/18/23 12:02, Peter Krempa wrote:
'qemuExtVhostUserGPUPrepareDomain' breaks our design
assumptions about
the 'PrepareDomain' step which should not touch anything on the host.
This patchset for now fixes the symptom by mocking the function and
poisons virFork and virCommandRun so that this doesn't happen in the
future.
Proper fix will require splitting the vhost-user GPU prepare step to
prepare the host-specific portion separately.
Peter Krempa (2):
qemuxml2argvmock: Mock qemuExtVhostUserGPUPrepareDomain
qemuxml2argvmock: Poison virCommandRun and virFork from test context
src/qemu/qemu_vhost_user_gpu.c | 4 ++++
src/qemu/qemu_vhost_user_gpu.h | 2 +-
src/util/vircommand.h | 4 ++--
tests/qemuxml2argvmock.c | 28 ++++++++++++++++++++++++++++
4 files changed, 35 insertions(+), 3 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal