Re: [PATCH v3 1/3] test_driver: Implement virDomainGetMessages

On Wed, Jun 30, 2021 at 10:53:44AM +0800, Luke Yue wrote: > Signed-off-by: Luke Yue <lukedyue(a)gmail.com&gt; > --- > src/test/test_driver.c | 53 > ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > If you first abstract the code from qemu driver then there's less code move to add this functionality.  Also one more thing to check is whether qemu driver is the only one that has this code and that it is not duplicated anywhere else - we could dedup even more code ;)