Re: [libvirt] [PATCH] vmware: make version parsing more robust
On 04/09/2014 11:59 AM, Jean-Baptiste Rouault wrote:
Since commit d69415d4, vmware version is parsed from both stdout and
stderr. This patch makes version parsing work even if there is garbage
(libvirt debug messages for example) in the command output.
For libvirt's debug messages, we have virLogProbablyLogMessage that can check
if the message matches libvirt's format.
Should we really ignore all garbage?
Jan
Attachments:
- signature.asc (application/pgp-signature — 836 bytes)