Re: [libvirt] [PATCH 7/9] nodeinfo: Add sysfs_prefix to nodeCapsInitNUMA
On Tue, 2015-07-07 at 20:26 -0400, John Ferlan wrote:
Add the sysfs_prefix argument to the call to allow for setting the
path for tests to something other than SYSFS_CPU_PATH which is a
derivative of SYSFS_SYSTEM_PATH
Use cpupath for nodeCapsInitNUMAFake and remove SYSFS_CPU_PATH
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
Just one remark below.
@@ -1810,26 +1811,27 @@ nodeGetMemoryFake(unsigned long long *mem,
/* returns 1 on success, 0 if the detection failed and -1 on hard
error */
static int
-virNodeCapsFillCPUInfo(int cpu_id ATTRIBUTE_UNUSED,
+virNodeCapsFillCPUInfo(const char *cpupath,
+ int cpu_id ATTRIBUTE_UNUSED,
virCapsHostNUMACellCPUPtr cpu
ATTRIBUTE_UNUSED)
cpupath should be marked ATTRIBUTE_UNUSED as well.
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team