Re: [libvirt] [PATCH] virconf: properly set the end of content

On Tue, Nov 07, 2017 at 03:37:46PM -0700, Jim Fehlig wrote: > There was a recent report of the xen-xl converter not handling > config files missing an ending newline > > https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html > > Commit 3cc2a9e0 fixed a similar problem when parsing content of a > file but missed parsing in-memory content. But AFAICT, the better > fix is to properly set the end of the content when initializing the > virConfParserCtxt in virConfParse(). > > This commit reverts the part of 3cc2a9e0 that appends a newline to > files missing it, and fixes setting the end of content when > initializing virConfParserCtxt. > > Signed-off-by: Jim Fehlig <jfehlig(a)suse.com&gt; > --- > src/util/virconf.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) Could you try to extend tests/virconftest.c to cover in-memory content for this newline scenario too.