Re: [libvirt] [PATCH] Wire up sysinfo for LXC driver
On 04/03/2013 11:59 AM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange(a)redhat.com>
The sysinfo code used by QEMU is trivially portable to the
LXC driver
---
src/lxc/lxc_conf.h | 3 +++
src/lxc/lxc_driver.c | 29 +++++++++++++++++++++++++++++
2 files changed, 32 insertions(+)
ACK.
+
+ if (virSysinfoFormat(&buf, driver->hostsysinfo) < 0)
+ return NULL;
+ if (virBufferError(&buf)) {
+ virReportOOMError();
Looks like virBufferError() in another one of those functions like
VIR_ALLOC and VIR_STRDUP where we ought to factor error handling into
the common function, and add a quiet variant for the outliers - but
that's for Michal to worry about in his series.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 621 bytes)