Re: [libvirt] [PATCH] docs: more on qemu locking patterns

On Tue, Feb 01, 2011 at 05:37:10PM -0700, Eric Blake wrote: > * src/qemu/THREADS.txt: Improve documentation. > --- > > qemuDomainObjExitMonitor() > - - Acquires the virDomainObjPtr lock > - Releases the qemuMonitorObjPtr lock > + - Acquires the virDomainObjPtr lock > > But I'm wondering if that was correct, or if the code should instead > be swapped to match the original ordering in the documentation. Either way doesn't matter. The lock ordering constraints only apply to sequences of 'lock' operations. You can 'unlock' any lock in any order, providing you always honour the 'lock' order. So changing the docs is fine.

> src/qemu/THREADS.txt | 100 ++++++++++++++++++++++++++++++++++++++----------- > 1 files changed, 77 insertions(+), 23 deletions(-) ACK