Re: [libvirt] [PATCH] filter blkio 0-device-weight at two oter places(was Re: [PATCHv4 4/4] blkiotune: add qemu support for blkiotune.device_weight)

On 11/29/2011 07:11 PM, Hu Tao wrote: s/oter/other/ Good catches, and your patch looks almost right. Here, we can't use 'j' as the key for whether to print a comma, but have to introduce a new variable. ACK with this squashed in, and pushed: diff --git i/src/qemu/qemu_driver.c w/src/qemu/qemu_driver.c index 0b1d6cf..ed90c66 100644 --- i/src/qemu/qemu_driver.c +++ w/src/qemu/qemu_driver.c @@ -6312,6 +6312,7 @@ static int qemuDomainGetBlkioParameters(virDomainPtr dom, if (vm->def->blkio.ndevices > 0) { virBuffer buf = VIR_BUFFER_INITIALIZER; bool comma = false; + for (j = 0; j < vm->def->blkio.ndevices; j++) { if (!vm->def->blkio.devices[j].weight) continue; @@ -6372,11 +6373,15 @@ static int qemuDomainGetBlkioParameters(virDomainPtr dom, case 1: /* blkiotune.device_weight */ if (persistentDef->blkio.ndevices > 0) { virBuffer buf = VIR_BUFFER_INITIALIZER; + bool comma = false; + for (j = 0; j < persistentDef->blkio.ndevices; j++) { if (!persistentDef->blkio.devices[j].weight) continue; - if (j) + if (comma) virBufferAddChar(&buf, ','); + else + comma = true; virBufferAsprintf(&buf, "%s,%u", persistentDef->blkio.devices[j].path, persistentDef->blkio.devices[j].weight); -- Eric Blake eblake(a)redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org