Re: [libvirt] [PATCH] PCI passthrough docs, tests and minor change
On Mon, Jan 12, 2009 at 11:46:38AM +0000, Daniel P. Berrange wrote:
> I also noticed that we parse (and save) and extra PCI domain
> argument, but it's not actually used when calling qemu, so I
> assume it's a missing feature for QEmu and just decided to patch
> the code to not save the extra value when not defined (i.e. 0).
NACK to this chunk - we should always output the 'domain' attribute
even when it is zero - it should only be optional when parsing the
XML. The fact that QEMU doesn't use it is just an impl artifact of
QEMU.
Then it need to be documented too, no way around since it will
always show up in dumps. And the fact it's not actually used must be
documented too. IMHO this just increase the long maintainance for
something you don't have any garantee to ever use.
Daniel
--
Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/
daniel(a)veillard.com | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library http://libvirt.org/