Re: [libvirt] [PATCH] tools: fix output of list with state-shutoff

On Mon, Nov 30, 2015 at 06:08:40PM +0800, Wei Jiangang wrote: >Due to the default of flags is VIR_CONNECT_LIST_DOMAINS_ACTIVE, >It doesn't show the domains that have been shutdown when we use >'virsh list' with only --state-shutoff. > >Signed-off-by: Wei Jiangang <weijg.fnst(a)cn.fujitsu.com&gt; >--- > tools/virsh-domain-monitor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c >index d4e500b..7b30c4c 100644 >--- a/tools/virsh-domain-monitor.c >+++ b/tools/virsh-domain-monitor.c >@@ -1873,7 +1873,8 @@ cmdList(vshControl *ctl, const vshCmd *cmd) > unsigned int flags = VIR_CONNECT_LIST_DOMAINS_ACTIVE; > > /* construct filter flags */ >- if (vshCommandOptBool(cmd, "inactive")) >+ if (vshCommandOptBool(cmd, "inactive") || >+ vshCommandOptBool(cmd, "state-shutoff")) > flags = VIR_CONNECT_LIST_DOMAINS_INACTIVE; > > if (vshCommandOptBool(cmd, "all")) >-- >1.9.3 > Unfortunately, the filters do not clearly align with what virsh allows the user to choose. This is probably the most clean way to make that work, so ACK. I will push it in a while.

> > >-- >libvir-list mailing list &gt;libvir-list(a)redhat.com >https://www.redhat.com/mailman/listinfo/libvir-list