On Fri, Oct 27, 2017 at 09:48:13AM +0200, Andrea Bolognani wrote:
Althought the environment variables are only used when running
libvirt's test suite, there is no harm in having it set in the
environment at all times.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
jobs/defaults.yaml | 2 ++
projects/libvirt.yaml | 3 ---
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/jobs/defaults.yaml b/jobs/defaults.yaml
index 0e628bb..a403d0e 100644
--- a/jobs/defaults.yaml
+++ b/jobs/defaults.yaml
@@ -10,5 +10,7 @@
MAKE='gmake'
fi
check_env: |
+ export VIR_TEST_EXPENSIVE=1
+ export VIR_TEST_DEBUG=2
smp: 3
spam: ymankad(a)redhat.com libvirt-ci(a)redhat.com
diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml
index 1b31c1b..5617e17 100644
--- a/projects/libvirt.yaml
+++ b/projects/libvirt.yaml
@@ -34,9 +34,6 @@
- libvirt-fedora-rawhide
- autotools-check-job:
parent_jobs: 'libvirt-master-syntax-check'
- check_env: |
- export VIR_TEST_EXPENSIVE=1
- export VIR_TEST_DEBUG=2
- autotools-rpm-job:
parent_jobs: 'libvirt-master-check'
- autotools-mingw-job:
I don't really see the benefit in this change - it is a currently project
specific env variable, in a project specific data file. Moving this into
a env that is defined for all projects makes no sense.
Regards,
Daniel
--
|:
https://berrange.com -o-
https://www.flickr.com/photos/dberrange :|
|:
https://libvirt.org -o-
https://fstop138.berrange.com :|
|:
https://entangle-photo.org -o-
https://www.instagram.com/dberrange :|