Re: [libvirt] [PATCHv2 3/3] xen_common: convert to typesafe virConf accessors

On Sun, May 27, 2018 at 1:17 PM, Ján Tomko <jtomko(a)redhat.com&gt; wrote: > On Sat, May 26, 2018 at 11:00:27PM +0200, Fabiano Fidêncio wrote: >> >> From: Fabiano Fidêncio <fidencio(a)redhat.com&gt; >> >> There are still some places using virConfGetValue() and then checking >> the specific type of the pointers and so on. >> >> Those place are not going to be changed as: >> - Directly using virConfGetValue*() would trigger virReportError() on >> their current code > > > Is that a problem in xenParseCPUFeatures? It would, at least, generate one more log, which would be misleading whoever ends up debugging some issue on that codepath later on.