Re: [libvirt] [PATCH v3 0/6] Add panic device support for S390
On Fri, 2016-04-29 at 15:23 +0200, Boris Fiuczynski wrote:
S390 architecture inherently provides a crash detection capability
which has not been reflected in the domain xml.
This series adds an s390 model to the panic device which does not
allow an address to be specified and is by default created on S390
guests unless already provided.
v3:
* Merged S390 and S390X in the add default device function
* Changed and added tests
* Split out ISA panic device message into separate patch
* Adjusted documentation
v2:
* Grouped default panic device creation and required test code changes into
one patch.
* Added an s390 model instead of using default model for toleration.
Boris Fiuczynski (6):
qemu: add panic device support for S390
qemu: add default panic device to S390 guests
tests: add tests for panic device model s390
docs: align spelling of S390
qemu: merge S390 and S390X default device creation
qemu: fix error message for default panic device
ACK series and pushed.
I have shuffled patches around a bit before doing so: patch
5/6 made much more sense if applied before patch 2/6, and
just like it patches 4/6 and 6/6 did not depend on the new
feature, so I've moved all of them at the beginning of the
series.
I've also adjusted the documentation slightly.
Test cases were still not perfect, but I didn't feel like
it was worth asking you to tweak the series again. I'll
prepare a follow-up commit shortly.
Thank you for your contribution :)
--
Andrea Bolognani
Software Engineer - Virtualization Team