Re: [libvirt] [PATCH 2/2] virt-driver-qemu.m4: Require YAJL

On Wed, Mar 13, 2019 at 04:50:38PM +0100, Michal Privoznik wrote: > There is not way that qemu driver can work without being able to s/not/no/ > format/parse JSON. > > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > m4/virt-driver-qemu.m4 | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/m4/virt-driver-qemu.m4 b/m4/virt-driver-qemu.m4 > index 80e1d3ad46..af8edaae0d 100644 > --- a/m4/virt-driver-qemu.m4 > +++ b/m4/virt-driver-qemu.m4 > @@ -26,6 +26,15 @@ AC_DEFUN([LIBVIRT_DRIVER_ARG_QEMU], [ > ]) > > AC_DEFUN([LIBVIRT_DRIVER_CHECK_QEMU], [ > + dnl There is no way qemu driver will work without JSON support > + AC_REQUIRE([LIBVIRT_CHECK_YAJL]) > + if test "$with_qemu:$with_yajl" = "yes:no"; then > + AC_MSG_ERROR([YAJL or YAJL2 is required to build QEMU driver]) > + fi > + if test "$with_qemu" = "check"; then > + with_qemu=$with_yajl > + fi > + Note that the default for with_qemu is still 'yes', so developers would have to opt-in by passing --with-qemu=check

Reviewed-by: Ján Tomko <jtomko(a)redhat.com&gt;