Re: [libvirt] [PATCH] qemu: Ignore missing query-migrate-parameters
On Wed, Apr 26, 2017 at 11:25:46PM +0200, Jiri Denemark wrote:
Trivially no migration parameters are supported when
query-migrate-parameters QMP command is missing. There's no need to
report an error in such case especially when doing so breaks
compatibility with old QEMU.
I'd suggest adjusting the commit message a bit, since the important part is
that there's a regression, the migration should work regardless of the presence
of the QMP command, and without your patch, it doesn't.
ACK
Erik
https://bugzilla.redhat.com/show_bug.cgi?id=1441934
Signed-off-by: Jiri Denemark <jdenemar(a)redhat.com>
---
src/qemu/qemu_monitor_json.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c
index 98e3c53f5..083729003 100644
--- a/src/qemu/qemu_monitor_json.c
+++ b/src/qemu/qemu_monitor_json.c
@@ -2660,6 +2660,11 @@ qemuMonitorJSONGetMigrationParams(qemuMonitorPtr mon,
if (qemuMonitorJSONCommand(mon, cmd, &reply) < 0)
goto cleanup;
+ if (qemuMonitorJSONHasError(reply, "CommandNotFound")) {
+ ret = 0;
+ goto cleanup;
+ }
+
if (qemuMonitorJSONCheckError(cmd, reply) < 0)
goto cleanup;
--
2.12.2
--
libvir-list mailing list
libvir-list(a)redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list