Re: [libvirt] [PATCH 12/13] util: storage: Store PR manager alias in the definition
On 05/14/2018 11:19 AM, Michal Privoznik wrote:
On 05/14/2018 12:45 PM, Peter Krempa wrote:
> Rather than always re-generating the alias store it in the definition
> and in the status XML.
>
> Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
> ---
> src/qemu/qemu_command.c | 23 +++------------------
> src/qemu/qemu_command.h | 3 +--
> src/qemu/qemu_domain.c | 16 +++++++++++++--
> src/qemu/qemu_hotplug.c | 34 ++++++++++---------------------
> src/util/virstoragefile.c | 1 +
> src/util/virstoragefile.h | 3 +++
> tests/qemustatusxml2xmldata/modern-in.xml | 4 ++++
> 7 files changed, 37 insertions(+), 47 deletions(-)
Yes, this makes sense to me. I've kept alias in status XML for all the
versions until the very last one. You have my ACK, but since John was
opposed maybe we should ask for his opinion too (so that we don't go
behind his back).
I still see no purpose for an alias to be saved since it's static, but I
seem to be alone in that thinking. Just as much as I was alone in the
thinking that qemuDomainGetManagedPRAlias is unnecessary and that a
constant static string would work just the same. I'm also not convinced
that a non managed system should be supported, but I recall Michal
noting something during one of the reviews that it was useful for some
future work.
Shouldn't at the very least the formatting of the path and alias only
occur for !(flags & VIR_DOMAIN_DEF_FORMAT_INACTIVE)... Would mean
passing @flags to virStoragePRDefFormat. At the very least it'll make
it obvious about it's only being formatted for the active/status guest.
John