Re: [libvirt] [PATCH] Remove unused variables.
On Thu, 2015-09-24 at 09:35 +0200, Martin Kletzander wrote:
I was playing with coccinelle tool the other day and just for the fun
of
it, I tried removing some useless things from our code. And look
what
came up. No functional change, and we're down in the number of
lines
by
about a hundred.
The changes seem safe enough from a really quick look, but I
personally dislike having statements like
return someOtherFunction(with,
its,
own,
parameters);
unless the calling function is a very straightforward wrapper,
eg. the return statement is the only one in the body.
That's of course just my personal taste :)
Cheers.
--
Andrea Bolognani
Software Engineer - Virtualization Team