v4:
https://www.redhat.com/archives/libvir-list/2017-December/msg00282.html
But more recently reviewed:
https://www.redhat.com/archives/libvir-list/2018-February/msg00022.html
https://www.redhat.com/archives/libvir-list/2018-February/msg00015.html
https://www.redhat.com/archives/libvir-list/2018-February/msg00016.html
Changes since v4:
Pushed former patch 1/4 since it was ACK'd...
- Patch 2:
* Return NULL on error in virNWFilterObjListFindInstantiateFilter
instead of the somewhat obfuscated @obj which would be NULL as a
result of the virNWFilterObjEndAPI
* Use virNWFilterObjDemoteFromWrite prior to return obj when the
path was returning a write locked object.
- Patch 3:
* Reword the comment prior to virNWFilterObjListFindByNameLocked
in order to better explain what's happening
* Ensure the write lock occurs while the nwfilters lock is held.
* Fix the virNWFilterCountData setup
* Fix the formatting for the @def in virNWFilterObjListExportCallback
(there was an extra space)
- Patch 4:
* No change, still needs the official ACK/R-b though
NB: Testing done...
* Ran/passed the nwfilter concurrency test w/ the changes
* Ran/passed the Avocado nwfilter_update_lock, nwfilter_update_vm_running,
and virsh.nwfilter_undefine.error_test.acl_test tests - these were the
ones with the most nwfilter "interaction" that would cause issues at
various points in time during installation.
John Ferlan (3):
nwfilter: Convert _virNWFilterObj to use virObjectRWLockable
nwfilter: Convert _virNWFilterObjList to use virObjectRWLockable
nwfilter: Remove need for nwfilterDriverLock in some API's
src/conf/virnwfilterobj.c | 540 +++++++++++++++++++++++----------
src/conf/virnwfilterobj.h | 11 +-
src/libvirt_private.syms | 3 +-
src/nwfilter/nwfilter_driver.c | 71 ++---
src/nwfilter/nwfilter_gentech_driver.c | 11 +-
5 files changed, 427 insertions(+), 209 deletions(-)
--
2.13.6