Re: [libvirt] [libvirt-php] rewrite checking for libxml2
On Mon, Feb 21, 2011 at 03:32:38PM +0100, Michal Novotny wrote:
On 02/21/2011 03:11 PM, Diego Elio Pettenò wrote:
>Il giorno lun, 21/02/2011 alle 14.40 +0100, Michal Novotny ha scritto:
>>Do you think this code is bad ?
>I think that from a distribution point of view, doing this is a huge
>pain. The moment pkg-config is upgraded and the macros need updating, a
>simple rebuild of autotools is not going to fix them, nor a single "rm
>m4/pkg.m4" or similar (which you can do with libtool).
>
Well, I am not that much familiar with autotools.
Lyre, could you please rewrite without the code Diego doesn't like,
i.e. this code?
If you just 'git rm aclocal.m4' then everything will be fine. This
file simply shouldn't be in GIT
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|