Re: [libvirt] [PATCH 1/2] qemu: fix some small issue in qemuProcessAttach

On 12/01/2014 06:27 PM, Martin Kletzander wrote: > On Mon, Dec 01, 2014 at 11:17:54AM +0100, Martin Kletzander wrote: >> On Mon, Dec 01, 2014 at 05:54:35PM +0800, Luyao Huang wrote: >>> There are some small issue in qemuProcessAttach: >>> >>> 1.Fix virSecurityManagerGetProcessLabel always get pid = 0, >>> move 'vm->pid = pid' before call virSecurityManagerGetProcessLabel. >>> >>> 2.Use virSecurityManagerGenLabel to get image label. >>> >>> 3.Fix always set selinux label for other security driver label. >>> >>> Signed-off-by: Luyao Huang <lhuang(a)redhat.com&gt; >>> --- >>> src/qemu/qemu_process.c | 10 +++++++--- >>> 1 file changed, 7 insertions(+), 3 deletions(-) >>> >> >> It looks like we were doing everything already, but we just did it >> wrong. Nice catch! ACK. >> > > Oh, I spoke too soon. Two minor things are wrong with this patch that > I'll fixup before pushing: > > 1) The commit message summary is not very descriptive. When someone > will go over the git log he/she won't figure out what was the deal > from "fix some small issue:. > Thanks for pointing out, BTW, maybe qemuprocessattach will failed after this patch without the patch 2/2, because we should give a way to get process uid and gid in virSecurityDACGetProcessLabel otherwise it will always return -1 without a error settings.

I will edit Patch 2 and give a v2 in these days (otherwise i cannot use qemu-attach : )).