[PATCH 2/5] virDomainVcpuDefPostParse: Remove impossible check

From: Peter Krempa <pkrempa(a)redhat.com&gt; Many callers of 'virDomainDefGetVcpu' don't validate return value when iterating CPUs up to def->maxvcpus/virDomainDefGetVcpusMax. Remove this one. Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; --- src/conf/domain_postparse.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/conf/domain_postparse.c b/src/conf/domain_postparse.c index a07ec8d94e..38e731348d 100644 --- a/src/conf/domain_postparse.c +++ b/src/conf/domain_postparse.c @@ -1013,10 +1013,6 @@ virDomainVcpuDefPostParse(virDomainDef *def) for (i = 0; i < maxvcpus; i++) { vcpu = virDomainDefGetVcpu(def, i); - /* impossible but some compilers don't like it */ - if (!vcpu) - continue; - switch (vcpu->hotpluggable) { case VIR_TRISTATE_BOOL_ABSENT: if (vcpu->online) -- 2.50.1