Re: [libvirt] [PATCH] output status information during guest shutdown again
On 08/21/2012 09:03 AM, Gerd v. Egidy wrote:
Since the move to systemd libvirt-guests doesn't output this
progress
information anymore. This patch brings back this feature.
It is helpful to show the admin what the system is waiting for and what
is left of the timeout (e.g. for calibrating the shutdown timing of a ups).
Rewriting the current line with \r doesn't work anymore in the context
of systemd. So always write new lines, but move to 5 second intervals
to avoid flooding the console.
This is version 2 of the patch and includes fixes as suggested by Eric Blake.
This last sentence can go...
---
after the ---, so that git doesn't store it in the log (it's informative
for the email review, but not relevant to the long-term history).
Beyond that, you met my comments on v1, and I didn't spot anything else, so:
ACK and pushed.
--
Eric Blake eblake(a)redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 620 bytes)