Re: [libvirt] [jenkins-ci PATCH 2/3] guests: Don't expose 'jenkins' pseudo-package
On Wed, 2018-03-21 at 15:56 +0100, Pavel Hrdina wrote:
> + # Install packages needed for the Jenkins agent
> + - include: tasks/packages.yml
> + vars:
> + project: jenkins
> + when:
> + - flavor == "jenkins"
> +
> # Configure the Jenkins agent
> - include: tasks/jenkins.yml
> when:
Would it make sense to move the installation of packages needed
for Jenkins agent into the jenkins task to create a single unit
out of it?
Maybe. However, I really like the current flat structure, where
there is no task that includes another task, and site.yml is the
one including everything as needed. I think it makes it easier to
understand what's going on, so I'd prefer keeping it this way.
--
Andrea Bolognani / Red Hat / Virtualization