Re: [libvirt] [PATCH] qemuMigrationBeginPhase: Check for 'drive-mirror' for NBD
On Thu, Nov 07, 2013 at 06:20:22 -0700, Eric Blake wrote:
On 11/07/2013 06:15 AM, Michal Privoznik wrote:
> So far we are checking if qemu supports 'nbd-server-start'. This,
> however, makes no sense on the source as nbd-server-* is used on the
> destination. On the source the 'drive-mirror' is used instead.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
> ---
> src/qemu/qemu_migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
The only thing I'm worried about is whether we need to check if
drive-mirror actually supports streaming data to the NBD server. Was it
always supported by drive-mirror or was it added later?
Jirka