Re: [libvirt] [PATCH v2] storage: Allow runtime detection of scrub

On 02/15/2012 06:37 AM, Michal Privoznik wrote: > Currently, if scrub (used for wiping algorithms) is not present > at compile time, we don't support any other wiping algorithms than > zeroing, even if it was installed later. Switch to runtime detection > instead. > --- > diff to v1: > -Add BuildRequires to spec file > > configure.ac | 30 ++++-------------------------- > libvirt.spec.in | 3 +++ > src/storage/storage_driver.c | 4 ---- > 3 files changed, 7 insertions(+), 30 deletions(-) > +++ b/libvirt.spec.in > @@ -513,6 +513,9 @@ BuildRequires: nfs-utils > # Fedora build root suckage > BuildRequires: gawk > > +# For storage wiping with different algorithms > +BuildRequires: scrub > + I'm wondering if this should be protected by a conditional, such as the %if %{with_storage_fs} conditional a few lines earlier. Then again, that example a few lines earlier was for $UMOUNT, used only in src/storage/storage_backend_fs.c, which is conditional, while your use of $SCRUB is in src/storage/storage_driver.c which is unconditionally built. So I think you're okay. ACK.