Re: [libvirt] [PATCH 0/5] libxl: user-specified domain config improvements

On 19.09.2014 21:23, Jim Fehlig wrote: > This is essentially a V2 of Stefan's patch to add support > for user-specified video device in the libxl driver. > > https://www.redhat.com/archives/libvir-list/2014-September/msg01157.html > > It goes a bit further and adds support for user-specfied <emulator>, > which was trivial to add after introducing libxlDomainGetEmulatorType > in patch 3. To ease review, the series has been split up as follows: > > - Missed keymap config from commit 4dfc34c3 split out to patch 1 > - Patch 2 added to defer setting default vram value to the Xen drivers > - Patch 3 added to detect old qemu-dm vs qemu with xen support > - Patch 4 is a slightly reworked version of Stefan's patch > - Patch 5 added to support user-specified <emulator> > > Jim Fehlig (4): > libxl: Copy user-specified keymap to libxl build info struct > Xen: Defer setting default vram value to Xen drivers > libxl: Add function to determine device model type > libxl: Support user-specified <emulator> > > Stefan Bader (1): > libxl: Implement basic video device selection > > src/conf/domain_conf.c | 4 ++ > src/libxl/libxl_conf.c | 124 > +++++++++++++++++++++++++++++++++++++++++++++++ > src/libxl/libxl_conf.h | 3 ++ > src/libxl/libxl_domain.c | 22 +++++++++ > src/xen/xen_driver.c | 19 ++++++++ > 5 files changed, 172 insertions(+) > ACK series, but please see my inline comments.